Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b3f3b2e

Browse filesBrowse files
santigimenorvagg
authored andcommitted
test: fix cluster-worker-isdead
Check if the worker 'isDead' instead of 'isConnected' as the 'disconnect' event is not guaranteed to be received before the 'exit' event. Remove the 'net' dependency as it is not used. PR-URL: #3954 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
1 parent e3a8e8b commit b3f3b2e
Copy full SHA for b3f3b2e

File tree

Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-cluster-worker-isdead.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cluster-worker-isdead.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
require('../common');
33
var cluster = require('cluster');
44
var assert = require('assert');
5-
var net = require('net');
65

76
if (cluster.isMaster) {
87
var worker = cluster.fork();
@@ -11,7 +10,7 @@ if (cluster.isMaster) {
1110
'created.');
1211

1312
worker.on('exit', function() {
14-
assert.ok(!worker.isConnected(),
13+
assert.ok(worker.isDead(),
1514
'After an event has been emitted, ' +
1615
'isDead should return true');
1716
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.