Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b395b16

Browse filesBrowse files
anonrigdanielleadams
authored andcommitted
url: use ada::url_aggregator for parsing urls
PR-URL: #47339 Backport-PR-URL: #48345 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 96c50ba commit b395b16
Copy full SHA for b395b16

File tree

Expand file treeCollapse file tree

9 files changed

+478
-257
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

9 files changed

+478
-257
lines changed
Open diff view settings
Collapse file

‎lib/internal/url.js‎

Copy file name to clipboardExpand all lines: lib/internal/url.js
+198-60Lines changed: 198 additions & 60 deletions
Large diffs are not rendered by default.
Collapse file

‎lib/url.js‎

Copy file name to clipboardExpand all lines: lib/url.js
+2-4Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,7 @@ const {
5959
urlToHttpOptions,
6060
} = require('internal/url');
6161

62-
const {
63-
formatUrl,
64-
} = internalBinding('url');
62+
const bindingUrl = internalBinding('url');
6563

6664
const { getOptionValue } = require('internal/options');
6765

@@ -627,7 +625,7 @@ function urlFormat(urlObject, options) {
627625
}
628626
}
629627

630-
return formatUrl(urlObject.href, fragment, unicode, search, auth);
628+
return bindingUrl.format(urlObject.href, fragment, unicode, search, auth);
631629
}
632630

633631
return Url.prototype.format.call(urlObject);
Collapse file

‎src/node_snapshotable.cc‎

Copy file name to clipboardExpand all lines: src/node_snapshotable.cc
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
#include "node_metadata.h"
1919
#include "node_process.h"
2020
#include "node_snapshot_builder.h"
21+
#include "node_url.h"
2122
#include "node_util.h"
2223
#include "node_v8.h"
2324
#include "node_v8_platform-inl.h"
Collapse file

‎src/node_snapshotable.h‎

Copy file name to clipboardExpand all lines: src/node_snapshotable.h
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ struct PropInfo {
2727
V(v8_binding_data, v8_utils::BindingData) \
2828
V(blob_binding_data, BlobBindingData) \
2929
V(process_binding_data, process::BindingData) \
30+
V(url_binding_data, url::BindingData) \
3031
V(util_weak_reference, util::WeakReference)
3132

3233
enum class EmbedderObjectType : uint8_t {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.