Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit b30840d

Browse filesBrowse files
Matheus Marchinitargos
Matheus Marchini
authored and
targos
committed
deps: fix gypi sysroot settings on V8
On Node.js v8.x, gn will pass a sysroot parameter to clang to use a downloaded sysroot files while running `make test-v8`. Recently, chromium build tools switched to use Debian sid sysroot files instead of Debian jessie. This patch updates our V8 GYP files to conform with those changes. Ref: #21433 PR-URL: #21494 Refs: #21433 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 45a8376 commit b30840d
Copy full SHA for b30840d

File tree

Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Collapse file

‎deps/v8/gypfiles/standalone.gypi‎

Copy file name to clipboardExpand all lines: deps/v8/gypfiles/standalone.gypi
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,16 +93,16 @@
9393
['OS=="linux" and use_sysroot==1', {
9494
'conditions': [
9595
['target_arch=="arm"', {
96-
'sysroot%': '<!(cd <(DEPTH) && pwd -P)/build/linux/debian_jessie_arm-sysroot',
96+
'sysroot%': '<!(cd <(DEPTH) && pwd -P)/build/linux/debian_sid_arm-sysroot',
9797
}],
9898
['target_arch=="x64"', {
99-
'sysroot%': '<!(cd <(DEPTH) && pwd -P)/build/linux/debian_jessie_amd64-sysroot',
99+
'sysroot%': '<!(cd <(DEPTH) && pwd -P)/build/linux/debian_sid_amd64-sysroot',
100100
}],
101101
['target_arch=="ia32"', {
102-
'sysroot%': '<!(cd <(DEPTH) && pwd -P)/build/linux/debian_jessie_i386-sysroot',
102+
'sysroot%': '<!(cd <(DEPTH) && pwd -P)/build/linux/debian_sid_i386-sysroot',
103103
}],
104104
['target_arch=="mipsel"', {
105-
'sysroot%': '<!(cd <(DEPTH) && pwd -P)/build/linux/debian_jessie_mips-sysroot',
105+
'sysroot%': '<!(cd <(DEPTH) && pwd -P)/build/linux/debian_sid_mips-sysroot',
106106
}],
107107
],
108108
}], # OS=="linux" and use_sysroot==1

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.