Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b301a7b

Browse filesBrowse files
Trotttargos
authored andcommitted
test: remove string literal message in assertions
Remove string literal message in assert.strictEqual() calls in test-async-await.js. Backport-PR-URL: #22912 PR-URL: #22849 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent a15bfda commit b301a7b
Copy full SHA for b301a7b

File tree

Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Open diff view settings
Collapse file

‎test/async-hooks/test-async-await.js‎

Copy file name to clipboardExpand all lines: test/async-hooks/test-async-await.js
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,15 @@ const timeout = common.platformTimeout(10);
6464

6565
function checkPromisesInitState() {
6666
for (const initState of promisesInitState.values()) {
67-
assert.strictEqual(initState, 'resolved',
68-
'promise initialized without being resolved');
67+
// Promise should not be initialized without being resolved.
68+
assert.strictEqual(initState, 'resolved');
6969
}
7070
}
7171

7272
function checkPromisesExecutionState() {
7373
for (const executionState of promisesExecutionState.values()) {
74-
assert.strictEqual(executionState, 'after',
75-
'mismatch between before and after hook calls');
74+
// Check for mismatch between before and after hook calls.
75+
assert.strictEqual(executionState, 'after');
7676
}
7777
}
7878

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.