Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b29b235

Browse filesBrowse files
herschel666codebytere
authored andcommitted
test: fix arguments order in assertions
Have the actual value first & the expected value second. PR-URL: #24149 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent d4fd76a commit b29b235
Copy full SHA for b29b235

File tree

Expand file treeCollapse file tree

1 file changed

+8
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+8
-8
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-process-env.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-process-env.js
+8-8Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@ const assert = require('assert');
2626

2727
// changes in environment should be visible to child processes
2828
if (process.argv[2] === 'you-are-the-child') {
29-
assert.strictEqual(false, 'NODE_PROCESS_ENV_DELETED' in process.env);
30-
assert.strictEqual('42', process.env.NODE_PROCESS_ENV);
31-
assert.strictEqual('asdf', process.env.hasOwnProperty);
29+
assert.strictEqual('NODE_PROCESS_ENV_DELETED' in process.env, false);
30+
assert.strictEqual(process.env.NODE_PROCESS_ENV, '42');
31+
assert.strictEqual(process.env.hasOwnProperty, 'asdf');
3232
const hasOwnProperty = Object.prototype.hasOwnProperty;
3333
const has = hasOwnProperty.call(process.env, 'hasOwnProperty');
34-
assert.strictEqual(true, has);
34+
assert.strictEqual(has, true);
3535
process.exit(0);
3636
}
3737

@@ -41,18 +41,18 @@ if (process.argv[2] === 'you-are-the-child') {
4141
assert.strictEqual(Object.prototype.hasOwnProperty,
4242
process.env.hasOwnProperty);
4343
const has = process.env.hasOwnProperty('hasOwnProperty');
44-
assert.strictEqual(false, has);
44+
assert.strictEqual(has, false);
4545

4646
process.env.hasOwnProperty = 'asdf';
4747

4848
process.env.NODE_PROCESS_ENV = 42;
49-
assert.strictEqual('42', process.env.NODE_PROCESS_ENV);
49+
assert.strictEqual(process.env.NODE_PROCESS_ENV, '42');
5050

5151
process.env.NODE_PROCESS_ENV_DELETED = 42;
52-
assert.strictEqual(true, 'NODE_PROCESS_ENV_DELETED' in process.env);
52+
assert.strictEqual('NODE_PROCESS_ENV_DELETED' in process.env, true);
5353

5454
delete process.env.NODE_PROCESS_ENV_DELETED;
55-
assert.strictEqual(false, 'NODE_PROCESS_ENV_DELETED' in process.env);
55+
assert.strictEqual('NODE_PROCESS_ENV_DELETED' in process.env, false);
5656

5757
const child = spawn(process.argv[0], [process.argv[1], 'you-are-the-child']);
5858
child.stdout.on('data', function(data) { console.log(data.toString()); });

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.