Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b296bd5

Browse filesBrowse files
danbevMylesBorins
authored andcommitted
src: remove TODO about uv errno removal
This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion. PR-URL: #12536 Ref: #4641 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 928382d commit b296bd5
Copy full SHA for b296bd5

File tree

Expand file treeCollapse file tree

1 file changed

+0
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-2
lines changed
Open diff view settings
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -938,8 +938,6 @@ Local<Value> UVException(Isolate* isolate,
938938

939939
Local<Object> e = Exception::Error(js_msg)->ToObject(isolate);
940940

941-
// TODO(piscisaureus) errno should probably go; the user has no way of
942-
// knowing which uv errno value maps to which error.
943941
e->Set(env->errno_string(), Integer::New(isolate, errorno));
944942
e->Set(env->code_string(), js_code);
945943
e->Set(env->syscall_string(), js_syscall);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.