Commit b0a557e
build: add correct shared library naming on OS X
The build system currently creates a shared library on OS X with the
same name as on Linux i.e. libnode.so.48. This is inconsistent with
the conventions on OS X which uses libnode.48.so This commit changes
the build process and install.py (used by make binary) to build with
the correct name on OS X when the --shared configure parameter is used.
PR-URL: #7687
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Conflicts:
node.gyp1 parent 6ed4ea8 commit b0a557eCopy full SHA for b0a557e
File tree
Expand file treeCollapse file tree
3 files changed
+11
-6
lines changedOpen diff view settings
Filter options
- tools
Expand file treeCollapse file tree
3 files changed
+11
-6
lines changedOpen diff view settings
Collapse file
+5-1Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
840 | 840 | |
841 | 841 | |
842 | 842 | |
843 | | - |
| 843 | + |
| 844 | + |
| 845 | + |
| 846 | + |
| 847 | + |
844 | 848 | |
845 | 849 | |
846 | 850 | |
|
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
248 | 248 | |
249 | 249 | |
250 | 250 | |
251 | | - |
| 251 | + |
252 | 252 | |
253 | 253 | |
254 | 254 | |
|
Collapse file
+5-4Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
118 | 118 | |
119 | 119 | |
120 | 120 | |
121 | | - |
122 | | - |
123 | | - |
124 | | - |
| 121 | + |
| 122 | + |
| 123 | + |
| 124 | + |
| 125 | + |
125 | 126 | |
126 | 127 | |
127 | 128 | |
|
0 commit comments