Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b044256

Browse filesBrowse files
Trotttargos
authored andcommitted
build: use LC_ALL of C for maximum compatibility
LC_ALL=en_US breaks on some systems (notably the SmartOS 16 configuration in our CI). Use LC_ALL=C instead. PR-URL: #21222 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 4e742e3 commit b044256
Copy full SHA for b044256

File tree

Expand file treeCollapse file tree

1 file changed

+1
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-4
lines changed
Open diff view settings
Collapse file

‎configure‎

Copy file name to clipboardExpand all lines: configure
+1-4Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -672,10 +672,7 @@ def get_xcode_version(cc):
672672
def get_gas_version(cc):
673673
try:
674674
custom_env = os.environ.copy()
675-
# smartos (a.k.a. sunos5) does not have the en_US locale, and will give:
676-
# `setlocale: LC_ALL: cannot change locale (en_US): Invalid argument`
677-
if 'sunos' not in sys.platform:
678-
custom_env["LC_ALL"] = "en_US"
675+
custom_env["LC_ALL"] = "C"
679676
proc = subprocess.Popen(shlex.split(cc) + ['-Wa,-v', '-c', '-o',
680677
'/dev/null', '-x',
681678
'assembler', '/dev/null'],

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.