Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit b00c087

Browse filesBrowse files
joyeecheungRafaelGSS
joyeecheung
authored and
RafaelGSS
committed
deps: V8: cherry-pick e74d0f437fcd
Original commit message: [api] add v8::Isolate::GetDefaultLocale() This allows embedders to query the default locale used by Intl APIs. This information is already available to user land via Intl?.Collator().resolvedOptions().locale, the issue with this is that it's a lot slower and requires dynamic access to Intl API, which is subject to patching and prototype pollution so it's not as reliable for embedders than having a V8 API to query the default locale directly. Refs: #54279 Change-Id: I5a1823993c9ae79f8f61f54c6464daf882a09ba3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5772938 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#95678} Refs: v8/v8@e74d0f4 PR-URL: #54279 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent c10aff6 commit b00c087
Copy full SHA for b00c087

File tree

Expand file treeCollapse file tree

3 files changed

+19
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+19
-1
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.18',
39+
'v8_embedder_string': '-node.19',
4040

4141
##### V8 defaults for Node.js #####
4242

Collapse file

‎deps/v8/include/v8-isolate.h‎

Copy file name to clipboardExpand all lines: deps/v8/include/v8-isolate.h
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include <stdint.h>
1010

1111
#include <memory>
12+
#include <string>
1213
#include <utility>
1314

1415
#include "cppgc/common.h"
@@ -1711,6 +1712,12 @@ class V8_EXPORT Isolate {
17111712
*/
17121713
void LocaleConfigurationChangeNotification();
17131714

1715+
/**
1716+
* Returns the default locale in a string if Intl support is enabled.
1717+
* Otherwise returns an empty string.
1718+
*/
1719+
std::string GetDefaultLocale();
1720+
17141721
Isolate() = delete;
17151722
~Isolate() = delete;
17161723
Isolate(const Isolate&) = delete;
Collapse file

‎deps/v8/src/api/api.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/api/api.cc
+11Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10577,6 +10577,17 @@ void v8::Isolate::LocaleConfigurationChangeNotification() {
1057710577
#endif // V8_INTL_SUPPORT
1057810578
}
1057910579

10580+
std::string Isolate::GetDefaultLocale() {
10581+
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(this);
10582+
ENTER_V8_NO_SCRIPT_NO_EXCEPTION(i_isolate);
10583+
10584+
#ifdef V8_INTL_SUPPORT
10585+
return i_isolate->DefaultLocale();
10586+
#else
10587+
return std::string();
10588+
#endif
10589+
}
10590+
1058010591
#if defined(V8_OS_WIN) && defined(V8_ENABLE_ETW_STACK_WALKING)
1058110592
void Isolate::SetFilterETWSessionByURLCallback(
1058210593
FilterETWSessionByURLCallback callback) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.