Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit afe1e00

Browse filesBrowse files
Trotttargos
authored andcommitted
build: remove Python 2 workaround
Remove workaround for Python 2. I confirmed that V8 build still works by running `./configure.py && make v8`. PR-URL: #41357 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
1 parent d4a6f2c commit afe1e00
Copy full SHA for afe1e00

File tree

Expand file treeCollapse file tree

1 file changed

+1
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-7
lines changed
Open diff view settings
Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py
+1-7Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@
1414
import bz2
1515
import io
1616

17-
# Fallback to find_executable from distutils.spawn is a stopgap for
18-
# supporting V8 builds, which do not yet support Python 3.
19-
try:
20-
from shutil import which
21-
except ImportError:
22-
from distutils.spawn import find_executable as which
2317
from distutils.version import StrictVersion
2418

2519
# If not run from node/, cd to node/.
@@ -1859,7 +1853,7 @@ def make_bin_override():
18591853
# sys.executable. This directory will be prefixed to the PATH, so that
18601854
# other tools that shell out to `python` will use the appropriate python
18611855

1862-
which_python = which('python')
1856+
which_python = shutil.which('python')
18631857
if (which_python and
18641858
os.path.realpath(which_python) == os.path.realpath(sys.executable)):
18651859
return

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.