Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit af6e439

Browse filesBrowse files
mhdawsontargos
mhdawson
authored and
targos
committed
test: enable marking of failing coverage tests
Enable marking of coverage tests so that we can allow some tests to fail without blocking the generation of coverage data. This will later allow us to fail the coverage job if other kinds of errors occur and to capture which tests we believe are not running properly with coverage enabled. PR-URL: #25671 Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent f3179f7 commit af6e439
Copy full SHA for af6e439

File tree

Expand file treeCollapse file tree

3 files changed

+8
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+8
-3
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,8 @@ coverage-test: coverage-build
226226
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/gen/*.gcda
227227
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/*.gcda
228228
$(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/tracing/*.gcda
229-
-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage $(MAKE) $(COVTESTS)
229+
-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage \
230+
TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) $(COVTESTS)
230231
$(MAKE) coverage-report-js
231232
-(cd out && "../gcovr/scripts/gcovr" --gcov-exclude='.*deps' \
232233
--gcov-exclude='.*usr' -v -r Release/obj.target \
@@ -277,7 +278,7 @@ coverage-run-js:
277278
$(RM) -r out/$(BUILDTYPE)/.coverage
278279
$(MAKE) coverage-build-js
279280
-NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage CI_SKIP_TESTS=$(COV_SKIP_TESTS) \
280-
$(MAKE) jstest
281+
TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) jstest
281282
$(MAKE) coverage-report-js
282283

283284
.PHONY: test
Collapse file

‎test/root.status‎

Copy file name to clipboardExpand all lines: test/root.status
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,3 +159,7 @@ sequential/test-inspector-port-cluster: SLOW
159159
sequential/test-net-bytes-per-incoming-chunk-overhead: SLOW
160160
sequential/test-pipe: SLOW
161161
sequential/test-util-debug: SLOW
162+
163+
[$type==coverage]
164+
js-native-api/test_function/test: PASS,FAIL,CRASH
165+
js-native-api/test_general/testFinalizer: PASS,FAIL,CRASH
Collapse file

‎tools/test.py‎

Copy file name to clipboardExpand all lines: tools/test.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1391,7 +1391,7 @@ def BuildOptions():
13911391
help='Send SIGABRT instead of SIGTERM to kill processes that time out',
13921392
default=False, action="store_true", dest="abort_on_timeout")
13931393
result.add_option("--type",
1394-
help="Type of build (simple, fips)",
1394+
help="Type of build (simple, fips, coverage)",
13951395
default=None)
13961396
return result
13971397

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.