Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit af645a0

Browse filesBrowse files
jalafelMyles Borins
authored andcommitted
doc: explain why GitHub merge button is not used
Adds documentation and explicit reasons on why the GitHub web interface button is not used. This was explained in the referenced issue by @thealphanerd. Fixes: #8893 PR-URL: #9044 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent a7ae887 commit af645a0
Copy full SHA for af645a0

File tree

Expand file treeCollapse file tree

1 file changed

+8
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+8
-1
lines changed
Open diff view settings
Collapse file

‎doc/onboarding.md‎

Copy file name to clipboardExpand all lines: doc/onboarding.md
+8-1Lines changed: 8 additions & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,15 @@ onboarding session.
164164

165165
## Landing PRs: Details
166166

167-
* Please never use GitHub's green "Merge Pull Request" button.
167+
* Please never use GitHub's green ["Merge Pull Request"](https://help.github.com/articles/merging-a-pull-request/#merging-a-pull-request-using-the-github-web-interface) button.
168168
* If you do, please force-push removing the merge.
169+
* Reasons for not using the web interface button:
170+
* The merge method will add an unnecessary merge commit.
171+
* The rebase & merge method adds metadata to the commit title.
172+
* The rebase method changes the author.
173+
* The squash & merge method has been known to add metadata to the commit title.
174+
* If more than one author has contributed to the PR, only the latest author will be considered during the squashing.
175+
169176

170177
Update your `master` branch (or whichever branch you are landing on, almost always `master`)
171178

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.