Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit af4b56d

Browse filesBrowse files
hefangshiMyles Borins
authored andcommitted
test: pass python path to node-gyp
node-gyp rebuild should use the same python interpreter as in Makefile rather than let node-gyp guess the python path by itself. PR-URL: #6646 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 7c55f59 commit af4b56d
Copy full SHA for af4b56d

File tree

Expand file treeCollapse file tree

1 file changed

+2
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-0
lines changed
Open diff view settings
Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ test-valgrind: all
123123

124124
test/gc/node_modules/weak/build/Release/weakref.node: $(NODE_EXE)
125125
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
126+
--python="$(PYTHON)" \
126127
--directory="$(shell pwd)/test/gc/node_modules/weak" \
127128
--nodedir="$(shell pwd)"
128129

@@ -142,6 +143,7 @@ test/addons/.buildstamp: $(ADDONS_BINDING_GYPS) | test/addons/.docbuildstamp
142143
# embedded addons have been generated from the documentation.
143144
for dirname in test/addons/*/; do \
144145
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
146+
--python="$(PYTHON)" \
145147
--directory="$$PWD/$$dirname" \
146148
--nodedir="$$PWD"; \
147149
done

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.