Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit af3acec

Browse filesBrowse files
committed
deps: V8: cherry-pick 3b6b21f595f6
Original commit message: [liftoff] Allow bailout for missing ARMv7 The bailout is there explicitly in the code, so we should allow it in {CheckBailoutAllowed}. R=ahaas@chromium.org Bug: v8:12527 Change-Id: Ifd906afb5f034f05c2bf7d9a28e3ab458549e7ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3372915 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78515} Refs: v8/v8@3b6b21f Fixes: #41402 PR-URL: #41457 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
1 parent 6aec92f commit af3acec
Copy full SHA for af3acec

File tree

Expand file treeCollapse file tree

3 files changed

+9
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+9
-2
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.12',
39+
'v8_embedder_string': '-node.13',
4040

4141
##### V8 defaults for Node.js #####
4242

Collapse file

‎deps/v8/src/wasm/baseline/arm/liftoff-assembler-arm.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/wasm/baseline/arm/liftoff-assembler-arm.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ inline void EmitAnyTrue(LiftoffAssembler* assm, LiftoffRegister dst,
438438

439439
int LiftoffAssembler::PrepareStackFrame() {
440440
if (!CpuFeatures::IsSupported(ARMv7)) {
441-
bailout(kUnsupportedArchitecture, "Armv6 not supported");
441+
bailout(kUnsupportedArchitecture, "Liftoff needs ARMv7");
442442
return 0;
443443
}
444444
uint32_t offset = static_cast<uint32_t>(pc_offset());
Collapse file

‎deps/v8/src/wasm/baseline/liftoff-compiler.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/wasm/baseline/liftoff-compiler.cc
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -310,6 +310,13 @@ void CheckBailoutAllowed(LiftoffBailoutReason reason, const char* detail,
310310
return;
311311
#endif
312312

313+
#if V8_TARGET_ARCH_ARM
314+
// Allow bailout for missing ARMv7 support.
315+
if (!CpuFeatures::IsSupported(ARMv7) && reason == kUnsupportedArchitecture) {
316+
return;
317+
}
318+
#endif
319+
313320
#define LIST_FEATURE(name, ...) kFeature_##name,
314321
constexpr WasmFeatures kExperimentalFeatures{
315322
FOREACH_WASM_EXPERIMENTAL_FEATURE_FLAG(LIST_FEATURE)};

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.