Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ae86192

Browse filesBrowse files
addaleaxtargos
authored andcommitted
src: ignore termination exceptions in fatal TryCatch
We don’t want these to terminate the process in case of Worker threads receiving a termination exception, rather than a “real one”. PR-URL: #25141 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
1 parent c9d49d6 commit ae86192
Copy full SHA for ae86192

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎src/node_errors.cc‎

Copy file name to clipboardExpand all lines: src/node_errors.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ void OnFatalError(const char* location, const char* message) {
315315
namespace errors {
316316

317317
TryCatchScope::~TryCatchScope() {
318-
if (HasCaught() && mode_ == CatchMode::kFatal) {
318+
if (HasCaught() && !HasTerminated() && mode_ == CatchMode::kFatal) {
319319
HandleScope scope(env_->isolate());
320320
ReportException(env_, Exception(), Message());
321321
exit(7);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.