Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ae3398a

Browse filesBrowse files
BridgeARMylesBorins
authored andcommitted
tools: fix eslint isRequired
Currently the call can lead to a TypeError with the message: `Cannot read property 'value' of undefined`. This fixes it by first checking that the first argument is truthy. PR-URL: #18729 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent 8e39c3b commit ae3398a
Copy full SHA for ae3398a

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎tools/eslint-rules/rules-utils.js‎

Copy file name to clipboardExpand all lines: tools/eslint-rules/rules-utils.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* require calls.
99
*/
1010
module.exports.isRequired = function(node, modules) {
11-
return node.callee.name === 'require' &&
11+
return node.callee.name === 'require' && node.arguments.length !== 0 &&
1212
modules.includes(node.arguments[0].value);
1313
};
1414

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.