Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ade27b7

Browse filesBrowse files
jasnellMylesBorins
authored andcommitted
src: use env->ThrowUVException in pipe_wrap
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #35493 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 0955267 commit ade27b7
Copy full SHA for ade27b7

File tree

Expand file treeCollapse file tree

1 file changed

+1
-3
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-3
lines changed
Open diff view settings
Collapse file

‎src/pipe_wrap.cc‎

Copy file name to clipboardExpand all lines: src/pipe_wrap.cc
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ using v8::Function;
4040
using v8::FunctionCallbackInfo;
4141
using v8::FunctionTemplate;
4242
using v8::Int32;
43-
using v8::Isolate;
4443
using v8::Local;
4544
using v8::MaybeLocal;
4645
using v8::Object;
@@ -216,9 +215,8 @@ void PipeWrap::Open(const FunctionCallbackInfo<Value>& args) {
216215
int err = uv_pipe_open(&wrap->handle_, fd);
217216
wrap->set_fd(fd);
218217

219-
Isolate* isolate = env->isolate();
220218
if (err != 0)
221-
isolate->ThrowException(UVException(isolate, err, "uv_pipe_open"));
219+
env->ThrowUVException(err, "uv_pipe_open");
222220
}
223221

224222

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.