Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ad69a65

Browse filesBrowse files
domreinMylesBorins
authored andcommitted
test: replaced literals in errors with templates
PR-URL: #15911 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 1690746 commit ad69a65
Copy full SHA for ad69a65

File tree

Expand file treeCollapse file tree

1 file changed

+27
-25
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+27
-25
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-buffer-indexof.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-buffer-indexof.js
+27-25Lines changed: 27 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -209,26 +209,26 @@ assert.strictEqual(
209209

210210
// Test single char pattern
211211
assert.strictEqual(0, twoByteString.indexOf('\u039a', 0, 'ucs2'));
212-
assert.strictEqual(2, twoByteString.indexOf('\u0391', 0, 'ucs2'),
213-
'Alpha');
214-
assert.strictEqual(4, twoByteString.indexOf('\u03a3', 0, 'ucs2'),
215-
'First Sigma');
216-
assert.strictEqual(6, twoByteString.indexOf('\u03a3', 6, 'ucs2'),
217-
'Second Sigma');
218-
assert.strictEqual(8, twoByteString.indexOf('\u0395', 0, 'ucs2'),
219-
'Epsilon');
220-
assert.strictEqual(-1, twoByteString.indexOf('\u0392', 0, 'ucs2'),
221-
'Not beta');
212+
let index = twoByteString.indexOf('\u0391', 0, 'ucs2');
213+
assert.strictEqual(2, index, `Alpha - at index ${index}`);
214+
index = twoByteString.indexOf('\u03a3', 0, 'ucs2');
215+
assert.strictEqual(4, index, `First Sigma - at index ${index}`);
216+
index = twoByteString.indexOf('\u03a3', 6, 'ucs2');
217+
assert.strictEqual(6, index, `Second Sigma - at index ${index}`);
218+
index = twoByteString.indexOf('\u0395', 0, 'ucs2');
219+
assert.strictEqual(8, index, `Epsilon - at index ${index}`);
220+
index = twoByteString.indexOf('\u0392', 0, 'ucs2');
221+
assert.strictEqual(-1, index, `Not beta - at index ${index}`);
222222

223223
// Test multi-char pattern
224-
assert.strictEqual(
225-
0, twoByteString.indexOf('\u039a\u0391', 0, 'ucs2'), 'Lambda Alpha');
226-
assert.strictEqual(
227-
2, twoByteString.indexOf('\u0391\u03a3', 0, 'ucs2'), 'Alpha Sigma');
228-
assert.strictEqual(
229-
4, twoByteString.indexOf('\u03a3\u03a3', 0, 'ucs2'), 'Sigma Sigma');
230-
assert.strictEqual(
231-
6, twoByteString.indexOf('\u03a3\u0395', 0, 'ucs2'), 'Sigma Epsilon');
224+
index = twoByteString.indexOf('\u039a\u0391', 0, 'ucs2');
225+
assert.strictEqual(0, index, `Lambda Alpha - at index ${index}`);
226+
index = twoByteString.indexOf('\u0391\u03a3', 0, 'ucs2');
227+
assert.strictEqual(2, index, `Alpha Sigma - at index ${index}`);
228+
index = twoByteString.indexOf('\u03a3\u03a3', 0, 'ucs2');
229+
assert.strictEqual(4, index, `Sigma Sigma - at index ${index}`);
230+
index = twoByteString.indexOf('\u03a3\u0395', 0, 'ucs2');
231+
assert.strictEqual(6, index, `Sigma Epsilon - at index ${index}`);
232232
}
233233

234234
const mixedByteStringUtf8 = Buffer.from('\u039a\u0391abc\u03a3\u03a3\u0395');
@@ -255,16 +255,18 @@ for (let i = 0; i < longBufferString.length - pattern.length; i += 7) {
255255
assert.strictEqual((i + 15) & ~0xf, index,
256256
`Long ABACABA...-string at index ${i}`);
257257
}
258-
assert.strictEqual(510, longBufferString.indexOf('AJABACA'),
259-
'Long AJABACA, First J');
260-
assert.strictEqual(
261-
1534, longBufferString.indexOf('AJABACA', 511), 'Long AJABACA, Second J');
258+
259+
let index = longBufferString.indexOf('AJABACA');
260+
assert.strictEqual(510, index, `Long AJABACA, First J - at index ${index}`);
261+
index = longBufferString.indexOf('AJABACA', 511);
262+
assert.strictEqual(1534, index, `Long AJABACA, Second J - at index ${index}`);
262263

263264
pattern = 'JABACABADABACABA';
265+
index = longBufferString.indexOf(pattern);
266+
assert.strictEqual(511, index, `Long JABACABA..., First J - at index ${index}`);
267+
index = longBufferString.indexOf(pattern, 512);
264268
assert.strictEqual(
265-
511, longBufferString.indexOf(pattern), 'Long JABACABA..., First J');
266-
assert.strictEqual(
267-
1535, longBufferString.indexOf(pattern, 512), 'Long JABACABA..., Second J');
269+
1535, index, `Long JABACABA..., Second J - at index ${index}`);
268270

269271
// Search for a non-ASCII string in a pure ASCII string.
270272
const asciiString = Buffer.from(

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.