Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ad63d35

Browse filesBrowse files
kohei-takatajasnell
authored andcommitted
readline: Remove XXX and output debuglog
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: #4690 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 8bad519 commit ad63d35
Copy full SHA for ad63d35

File tree

Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Collapse file

‎lib/readline.js‎

Copy file name to clipboardExpand all lines: lib/readline.js
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
const kHistorySize = 30;
1010

1111
const util = require('util');
12+
const debug = util.debuglog('readline');
1213
const internalUtil = require('internal/util');
1314
const inherits = util.inherits;
1415
const Buffer = require('buffer').Buffer;
@@ -380,7 +381,7 @@ Interface.prototype._tabComplete = function() {
380381
self.resume();
381382

382383
if (err) {
383-
// XXX Log it somewhere?
384+
debug('tab completion error %j', err);
384385
return;
385386
}
386387

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.