Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit ad41c91

Browse filesBrowse files
tniessentniessen
authored
src: remove v8abbr.h
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only used for dtrace, which has been removed. Refs: #43652 PR-URL: #44402 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
1 parent 3303a10 commit ad41c91
Copy full SHA for ad41c91

File tree

Expand file treeCollapse file tree

4 files changed

+8
-129
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

4 files changed

+8
-129
lines changed
Open diff view settings
Collapse file

‎.github/label-pr-config.yml‎

Copy file name to clipboardExpand all lines: .github/label-pr-config.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ subSystemLabels:
2121
/^src\/tty_/: c++, tty
2222
/^src\/node_url/: c++, whatwg-url
2323
/^src\/node_util/: c++, util
24-
/^src\/(?:node_v8|v8abbr)/: c++, v8 engine
24+
/^src\/node_v8/: c++, v8 engine
2525
/^src\/node_contextify/: c++, vm
2626
/^src\/.*win32.*/: c++, windows
2727
/^src\/node_zlib/: c++, zlib
Collapse file

‎src/node_postmortem_metadata.cc‎

Copy file name to clipboardExpand all lines: src/node_postmortem_metadata.cc
+5-4Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
#include "env.h"
21
#include "base_object-inl.h"
2+
#include "env.h"
33
#include "handle_wrap.h"
4-
#include "util-inl.h"
5-
#include "req_wrap.h"
6-
#include "v8abbr.h"
74
#include "node_context_data.h"
5+
#include "req_wrap.h"
6+
#include "util-inl.h"
7+
8+
#define NODE_OFF_EXTSTR_DATA sizeof(void*)
89

910
#define NODEDBG_SYMBOL(Name) nodedbg_ ## Name
1011

Collapse file

‎src/v8abbr.h‎

Copy file name to clipboardExpand all lines: src/v8abbr.h
-123Lines changed: 0 additions & 123 deletions
This file was deleted.
Collapse file

‎test/cctest/test_node_postmortem_metadata.cc‎

Copy file name to clipboardExpand all lines: test/cctest/test_node_postmortem_metadata.cc
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
#include "req_wrap-inl.h"
66
#include "tracing/agent.h"
77
#include "v8.h"
8-
#include "v8abbr.h"
8+
9+
#define NODE_OFF_EXTSTR_DATA sizeof(void*)
910

1011
extern "C" {
1112
extern uintptr_t

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.