Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit acbd822

Browse filesBrowse files
RaisinTentargos
authored andcommitted
src,crypto: use ByteSource::ToBuffer() in crypto_dh
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40903 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 1555dbd commit acbd822
Copy full SHA for acbd822

File tree

Expand file treeCollapse file tree

1 file changed

+2
-8
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-8
lines changed
Open diff view settings
Collapse file

‎src/crypto/crypto_dh.cc‎

Copy file name to clipboardExpand all lines: src/crypto/crypto_dh.cc
+2-8Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
namespace node {
1515

16-
using v8::ArrayBuffer;
1716
using v8::ConstructorBehavior;
1817
using v8::DontDelete;
1918
using v8::FunctionCallback;
@@ -610,13 +609,8 @@ void DiffieHellman::Stateless(const FunctionCallbackInfo<Value>& args) {
610609
ManagedEVPPKey our_key = our_key_object->Data()->GetAsymmetricKey();
611610
ManagedEVPPKey their_key = their_key_object->Data()->GetAsymmetricKey();
612611

613-
Local<Value> out;
614-
{
615-
Local<ArrayBuffer> ab = StatelessDiffieHellmanThreadsafe(our_key, their_key)
616-
.ToArrayBuffer(env);
617-
out = Buffer::New(env, ab, 0, ab->ByteLength())
618-
.FromMaybe(Local<Uint8Array>());
619-
}
612+
Local<Value> out = StatelessDiffieHellmanThreadsafe(our_key, their_key)
613+
.ToBuffer(env).FromMaybe(Local<Uint8Array>());
620614

621615
if (Buffer::Length(out) == 0)
622616
return ThrowCryptoError(env, ERR_get_error(), "diffieHellman failed");

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.