Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit abca97f

Browse filesBrowse files
Ceres6targos
authored andcommitted
test: change jenkins reporter
PR-URL: #56808 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 7c9fa11 commit abca97f
Copy full SHA for abca97f

File tree

Expand file treeCollapse file tree

2 files changed

+9
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+9
-5
lines changed
Open diff view settings
Collapse file

‎test/es-module/test-esm-no-addons.mjs‎

Copy file name to clipboardExpand all lines: test/es-module/test-esm-no-addons.mjs
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ if (isMainThread) {
1515
loadFixture('pkgexports/no-addons').then(
1616
mustCall((module) => {
1717
const message = module.default;
18-
19-
if (process.execArgv.length === 0) {
18+
if (!process.execArgv.includes('--no-addons')) {
2019
assert.strictEqual(message, 'using native addons');
2120
} else {
2221
assert.strictEqual(message, 'not using native addons');
Collapse file

‎tools/test.py‎

Copy file name to clipboardExpand all lines: tools/test.py
+8-3Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -316,9 +316,7 @@ def HasRun(self, output):
316316

317317
class ActionsAnnotationProgressIndicator(DotsProgressIndicator):
318318
def AboutToRun(self, case):
319-
case.additional_flags = case.additional_flags.copy() if hasattr(case, 'additional_flags') else []
320-
case.additional_flags.append('--test-reporter=./test/common/test-error-reporter.js')
321-
case.additional_flags.append('--test-reporter-destination=stdout')
319+
pass
322320

323321
def GetAnnotationInfo(self, test, output):
324322
traceback = output.stdout + output.stderr
@@ -1448,6 +1446,9 @@ def BuildOptions():
14481446
result.add_option("--type",
14491447
help="Type of build (simple, fips, coverage)",
14501448
default=None)
1449+
result.add_option("--error-reporter",
1450+
help="use error reporter",
1451+
default=True, action="store_true")
14511452
return result
14521453

14531454

@@ -1663,6 +1664,10 @@ def Main():
16631664
options.node_args.append("--always-turbofan")
16641665
options.progress = "deopts"
16651666

1667+
if options.error_reporter:
1668+
options.node_args.append('--test-reporter=./test/common/test-error-reporter.js')
1669+
options.node_args.append('--test-reporter-destination=stdout')
1670+
16661671
if options.worker:
16671672
run_worker = join(workspace, "tools", "run-worker.js")
16681673
options.node_args.append(run_worker)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.