Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ab50e82

Browse filesBrowse files
santigimenoMyles Borins
authored andcommitted
test: fix test-process-exec-argv flakiness
Wait for the `close` event before parsing the child stdout output. Fixes: #6480 Ref: #6575 PR-URL: #7128 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 67863f1 commit ab50e82
Copy full SHA for ab50e82

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-process-exec-argv.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-process-exec-argv.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ if (process.argv[2] === 'child') {
1515
out += chunk;
1616
});
1717

18-
child.on('exit', function() {
19-
assert.deepEqual(JSON.parse(out), execArgv);
18+
child.on('close', function() {
19+
assert.deepStrictEqual(JSON.parse(out), execArgv);
2020
});
2121
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.