Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit aa4f485

Browse filesBrowse files
anonrigdanielleadams
anonrig
authored and
danielleadams
committed
url: set formatUrl method as no side effect
PR-URL: #46884 Backport-PR-URL: #48345 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent c79e1b7 commit aa4f485
Copy full SHA for aa4f485

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎src/node_url.cc‎

Copy file name to clipboardExpand all lines: src/node_url.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ void Initialize(Local<Object> target,
313313
void* priv) {
314314
SetMethod(context, target, "parse", Parse);
315315
SetMethod(context, target, "updateUrl", UpdateUrl);
316-
SetMethod(context, target, "formatUrl", FormatUrl);
316+
SetMethodNoSideEffect(context, target, "formatUrl", FormatUrl);
317317

318318
SetMethodNoSideEffect(context, target, "domainToASCII", DomainToASCII);
319319
SetMethodNoSideEffect(context, target, "domainToUnicode", DomainToUnicode);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.