Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit aa2be4b

Browse filesBrowse files
privatenumberRafaelGSS
authored andcommitted
module: load source maps in commonjs translator
PR-URL: #51033 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 04eaa5c commit aa2be4b
Copy full SHA for aa2be4b

File tree

Expand file treeCollapse file tree

2 files changed

+35
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+35
-0
lines changed
Open diff view settings
Collapse file

‎lib/internal/modules/esm/translators.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/translators.js
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,8 @@ function createCJSModuleWrap(url, source, isMain, loadCJS = loadCJSModule) {
289289
// In case the source was not provided by the `load` step, we need fetch it now.
290290
source = stringify(source ?? getSource(new URL(url)).source);
291291

292+
maybeCacheSourceMap(url, source);
293+
292294
const { exportNames, module } = cjsPreparseModuleExports(filename, source);
293295
cjsCache.set(url, module);
294296
const namesWithDefault = exportNames.has('default') ?
Collapse file

‎test/es-module/test-esm-loader-hooks.mjs‎

Copy file name to clipboardExpand all lines: test/es-module/test-esm-loader-hooks.mjs
+33Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -747,6 +747,39 @@ describe('Loader hooks', { concurrency: true }, () => {
747747
assert.strictEqual(signal, null);
748748
});
749749

750+
it('should support source maps in commonjs translator', async () => {
751+
const readFile = async () => {};
752+
const hook = `
753+
import { readFile } from 'node:fs/promises';
754+
export ${
755+
async function load(url, context, nextLoad) {
756+
const resolved = await nextLoad(url, context);
757+
if (context.format === 'commonjs') {
758+
resolved.source = await readFile(new URL(url));
759+
}
760+
return resolved;
761+
}
762+
}`;
763+
764+
const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [
765+
'--no-warnings',
766+
'--enable-source-maps',
767+
'--import',
768+
`data:text/javascript,${encodeURIComponent(`
769+
import{ register } from "node:module";
770+
register(${
771+
JSON.stringify('data:text/javascript,' + encodeURIComponent(hook))
772+
});
773+
`)}`,
774+
fixtures.path('source-map/throw-on-require.js'),
775+
]);
776+
777+
assert.strictEqual(stdout, '');
778+
assert.match(stderr, /throw-on-require\.ts:9:9/);
779+
assert.strictEqual(code, 1);
780+
assert.strictEqual(signal, null);
781+
});
782+
750783
it('should handle mixed of opt-in modules and non-opt-in ones', async () => {
751784
const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [
752785
'--no-warnings',

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.