Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit aa08f64

Browse filesBrowse files
cjihrigMylesBorins
cjihrig
authored and
MylesBorins
committed
test: add read_only_space heap space
v8.getHeapSpaceStatistics() now includes read_only_space in its results. Update test-v8-stats.js to account for this. Fixes: nodejs/node-v8#44 PR-URL: #19989 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent 2d3137c commit aa08f64
Copy full SHA for aa08f64

File tree

Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-v8-stats.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-v8-stats.js
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ const expectedHeapSpaces = [
2525
'old_space',
2626
'code_space',
2727
'map_space',
28-
'large_object_space'
28+
'large_object_space',
29+
'read_only_space'
2930
];
3031
const heapSpaceStatistics = v8.getHeapSpaceStatistics();
3132
const actualHeapSpaceNames = heapSpaceStatistics.map((s) => s.space_name);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.