Commit a96cc31
test: speed up test-child-process-spawnsync.js
There's a bunch of stuff in test-child-process-spawnsync.js that seems
designed to test that it is in fact blocking/synchronous. However, that
code really just tests the OS sleep command. Change `sleep 1` to `sleep
0` and shave about one second off the test run.`
We check the return status to confirm the command is successful. The
tests in this file in general would not work if spawnSync() were
asynchronous. That includes this one, as a return status would not be
available if the command where asynchronous.
PR-URL: #2542
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent d2ffecb commit a96cc31Copy full SHA for a96cc31
File tree
Expand file treeCollapse file tree
1 file changed
+3
-14
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+3
-14
lines changedOpen diff view settings
Collapse file
test/parallel/test-child-process-spawnsync.js
Copy file name to clipboardExpand all lines: test/parallel/test-child-process-spawnsync.js+3-14Lines changed: 3 additions & 14 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
4 | 4 | |
5 | 5 | |
6 | 6 | |
7 | | - |
8 | | - |
9 | | - |
10 | | - |
11 | | - |
12 | | - |
13 | | - |
14 | | - |
15 | | - |
16 | | - |
17 | | - |
| 7 | + |
| 8 | + |
| 9 | + |
18 | 10 | |
19 | | - |
20 | | - |
21 | | - |
22 | 11 | |
23 | 12 | |
24 | 13 | |
|
0 commit comments