Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a93eaa4

Browse filesBrowse files
refackMylesBorins
authored andcommitted
test: performance, remove Popen(shell=True) on Win
not needed according to official python docs - https://docs.python.org/2/library/subprocess.html#index-2 PR-URL: #12138 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 5f928a8 commit a93eaa4
Copy full SHA for a93eaa4

File tree

Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-1
lines changed
Open diff view settings
Collapse file

‎tools/test.py‎

Copy file name to clipboardExpand all lines: tools/test.py
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -616,7 +616,6 @@ def RunProcess(context, timeout, args, **rest):
616616
pty_out = rest.pop('pty_out')
617617

618618
process = subprocess.Popen(
619-
shell = utils.IsWindows(),
620619
args = popen_args,
621620
**rest
622621
)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.