Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a8a7575

Browse filesBrowse files
addaleaxtargos
authored andcommitted
src: remove extra ReadStop() call
This is no longer necessary since libuv 1.21.0. PR-URL: #21528 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent b28fd37 commit a8a7575
Copy full SHA for a8a7575

File tree

Expand file treeCollapse file tree

2 files changed

+0
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+0
-7
lines changed
Open diff view settings
Collapse file

‎src/stream_wrap.cc‎

Copy file name to clipboardExpand all lines: src/stream_wrap.cc
-5Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -373,11 +373,6 @@ void LibuvStreamWrap::AfterUvWrite(uv_write_t* req, int status) {
373373
req_wrap->Done(status);
374374
}
375375

376-
void LibuvStreamWrap::Close(v8::Local<v8::Value> close_callback) {
377-
ReadStop();
378-
HandleWrap::Close(close_callback);
379-
}
380-
381376
} // namespace node
382377

383378
NODE_BUILTIN_MODULE_CONTEXT_AWARE(stream_wrap,
Collapse file

‎src/stream_wrap.h‎

Copy file name to clipboardExpand all lines: src/stream_wrap.h
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@ class LibuvStreamWrap : public HandleWrap, public StreamBase {
7676
ShutdownWrap* CreateShutdownWrap(v8::Local<v8::Object> object) override;
7777
WriteWrap* CreateWriteWrap(v8::Local<v8::Object> object) override;
7878

79-
void Close(v8::Local<v8::Value> close_callback) override;
80-
8179
protected:
8280
LibuvStreamWrap(Environment* env,
8381
v8::Local<v8::Object> object,

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.