Commit a7e49c8
committed
http_parser: use
Make `HTTPParser` an instance of `AsyncWrap` and make it use
`MakeCallback`. This means that async wrap hooks will be called on
consumed TCP sockets as well as on non-consumed ones.
Additional uses of `AsyncCallbackScope` are necessary to prevent
improper state from progressing that triggers failure in the
test-http-pipeline-flood.js test. Optimally this wouldn't be necessary,
but for the time being it's the most sure way to allow operations to
proceed as they have.
Fix: #4416
PR-URL: #5419
Reviewed-By: Fedor Indutny <fedor@indutny.com>MakeCallback
1 parent da3f425 commit a7e49c8Copy full SHA for a7e49c8
File tree
Expand file treeCollapse file tree
3 files changed
+22
-9
lines changedOpen diff view settings
Filter options
- src
- test/parallel
Expand file treeCollapse file tree
3 files changed
+22
-9
lines changedOpen diff view settings
Collapse file
+1Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
17 | 17 | |
18 | 18 | |
19 | 19 | |
| 20 | + |
20 | 21 | |
21 | 22 | |
22 | 23 | |
|
Collapse file
+18-9Lines changed: 18 additions & 9 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
2 | 2 | |
3 | 3 | |
4 | 4 | |
5 | | - |
6 | | - |
| 5 | + |
| 6 | + |
7 | 7 | |
8 | 8 | |
9 | 9 | |
| ||
147 | 147 | |
148 | 148 | |
149 | 149 | |
150 | | - |
| 150 | + |
151 | 151 | |
152 | 152 | |
153 | | - |
| 153 | + |
154 | 154 | |
155 | 155 | |
156 | 156 | |
| ||
164 | 164 | |
165 | 165 | |
166 | 166 | |
| 167 | + |
| 168 | + |
| 169 | + |
| 170 | + |
| 171 | + |
167 | 172 | |
168 | 173 | |
169 | 174 | |
| ||
285 | 290 | |
286 | 291 | |
287 | 292 | |
| 293 | + |
| 294 | + |
288 | 295 | |
289 | | - |
| 296 | + |
290 | 297 | |
291 | 298 | |
292 | 299 | |
| ||
321 | 328 | |
322 | 329 | |
323 | 330 | |
324 | | - |
| 331 | + |
325 | 332 | |
326 | 333 | |
327 | 334 | |
| ||
344 | 351 | |
345 | 352 | |
346 | 353 | |
347 | | - |
| 354 | + |
| 355 | + |
| 356 | + |
348 | 357 | |
349 | 358 | |
350 | 359 | |
| ||
584 | 593 | |
585 | 594 | |
586 | 595 | |
587 | | - |
| 596 | + |
588 | 597 | |
589 | 598 | |
590 | 599 | |
| ||
671 | 680 | |
672 | 681 | |
673 | 682 | |
674 | | - |
| 683 | + |
675 | 684 | |
676 | 685 | |
677 | 686 | |
|
Collapse file
test/parallel/test-async-wrap-check-providers.js
Copy file name to clipboardExpand all lines: test/parallel/test-async-wrap-check-providers.js+3Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
11 | 11 | |
12 | 12 | |
13 | 13 | |
| 14 | + |
14 | 15 | |
15 | 16 | |
16 | 17 | |
| ||
106 | 107 | |
107 | 108 | |
108 | 109 | |
| 110 | + |
| 111 | + |
109 | 112 | |
110 | 113 | |
111 | 114 | |
|
0 commit comments