Commit a7b3a75
test: be explicit about polluting of
There was a comment in `test-domain-crypto.js` indicating that the
pollution of the `global` object with a `domain` property was
intentional. Provide more information in the comment so someone may
easily determine why. Use `global.domain` rather than declaring `domain`
without the `var` keyword to more clearly signal that the pollution is
intentional.
PR-URL: #6017
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>global
1 parent 56755de commit a7b3a75Copy full SHA for a7b3a75
File tree
Expand file treeCollapse file tree
1 file changed
+3
-2
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
1 file changed
+3
-2
lines changedOpen diff view settings
Collapse file
test/parallel/test-domain-crypto.js
Copy file name to clipboardExpand all lines: test/parallel/test-domain-crypto.js+3-2Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
6 | 6 | |
7 | 7 | |
8 | 8 | |
9 | | - |
10 | | - |
| 9 | + |
| 10 | + |
| 11 | + |
11 | 12 | |
12 | 13 | |
13 | 14 | |
|
0 commit comments