Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a69d30e

Browse filesBrowse files
richardlauMylesBorins
authored andcommitted
module: drop -u alias for --conditions
Old versions of mocha break after #34637. This was a bug in mocha, but since this is a widely used module we can expect ecosystem breakage until modules are updated to the latest version of mocha. Drop the conflicting `-u` alias -- we can potentially bring it back once modules have been updated. PR-URL: #34935 Refs: mochajs/mocha#4417 Refs: #34637 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
1 parent cf34854 commit a69d30e
Copy full SHA for a69d30e

File tree

Expand file treeCollapse file tree

4 files changed

+4
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

4 files changed

+4
-5
lines changed
Open diff view settings
Collapse file

‎doc/api/cli.md‎

Copy file name to clipboardExpand all lines: doc/api/cli.md
+2-2Lines changed: 2 additions & 2 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ $ node --completion-bash > node_bash_completion
7676
$ source node_bash_completion
7777
```
7878

79-
### `-u`, `--conditions=condition`
79+
### `--conditions=condition`
8080
<!-- YAML
8181
added: REPLACEME
8282
-->
@@ -1214,7 +1214,7 @@ node --require "./a.js" --require "./b.js"
12141214

12151215
Node.js options that are allowed are:
12161216
<!-- node-options-node start -->
1217-
* `--conditions`, `-u`
1217+
* `--conditions`
12181218
* `--diagnostic-dir`
12191219
* `--disable-proto`
12201220
* `--enable-fips`
Collapse file

‎doc/node.1‎

Copy file name to clipboardExpand all lines: doc/node.1
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ Aborting instead of exiting causes a core file to be generated for analysis.
7878
.It Fl -completion-bash
7979
Print source-able bash completion script for Node.js.
8080
.
81-
.It Fl u , Fl -conditions Ar string
81+
.It Fl -conditions Ar string
8282
Use custom conditional exports conditions
8383
.Ar string
8484
.
Collapse file

‎src/node_options.cc‎

Copy file name to clipboardExpand all lines: src/node_options.cc
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,6 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
285285
"additional user conditions for conditional exports and imports",
286286
&EnvironmentOptions::conditions,
287287
kAllowedInEnvironment);
288-
AddAlias("-u", "--conditions");
289288
AddOption("--diagnostic-dir",
290289
"set dir for all output files"
291290
" (default: current working directory)",
Collapse file

‎test/es-module/test-esm-custom-exports.mjs‎

Copy file name to clipboardExpand all lines: test/es-module/test-esm-custom-exports.mjs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Flags: --conditions=custom-condition -u another
1+
// Flags: --conditions=custom-condition --conditions another
22
import { mustCall } from '../common/index.mjs';
33
import { strictEqual } from 'assert';
44
import { requireFixture, importFixture } from '../fixtures/pkgexports.mjs';

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.