Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a67e5ea

Browse filesBrowse files
legendecasMoLow
authored andcommitted
node-api: remove unused mark_arraybuffer_as_untransferable
napi_create_external_arraybuffer creates the arraybuffer with node::Buffer, which already marks the buffer as untransferable. The napi_env__::mark_arraybuffer_as_untransferable is not used anymore. PR-URL: #47557 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 75d7024 commit a67e5ea
Copy full SHA for a67e5ea

File tree

Expand file treeCollapse file tree

3 files changed

+0
-13
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+0
-13
lines changed
Open diff view settings
Collapse file

‎src/js_native_api_v8.h‎

Copy file name to clipboardExpand all lines: src/js_native_api_v8.h
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,6 @@ struct napi_env__ {
6666
}
6767

6868
virtual bool can_call_into_js() const { return true; }
69-
virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable(
70-
v8::Local<v8::ArrayBuffer> ab) const {
71-
return v8::Just(true);
72-
}
7369

7470
static inline void HandleThrow(napi_env env, v8::Local<v8::Value> value) {
7571
if (env->terminatedOrTerminating()) {
Collapse file

‎src/node_api.cc‎

Copy file name to clipboardExpand all lines: src/node_api.cc
-7Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,6 @@ bool node_napi_env__::can_call_into_js() const {
3535
return node_env()->can_call_into_js();
3636
}
3737

38-
v8::Maybe<bool> node_napi_env__::mark_arraybuffer_as_untransferable(
39-
v8::Local<v8::ArrayBuffer> ab) const {
40-
return ab->SetPrivate(context(),
41-
node_env()->untransferable_object_private_symbol(),
42-
v8::True(isolate));
43-
}
44-
4538
void node_napi_env__::CallFinalizer(napi_finalize cb, void* data, void* hint) {
4639
CallFinalizer<true>(cb, data, hint);
4740
}
Collapse file

‎src/node_api_internals.h‎

Copy file name to clipboardExpand all lines: src/node_api_internals.h
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ struct node_napi_env__ : public napi_env__ {
1313
const std::string& module_filename);
1414

1515
bool can_call_into_js() const override;
16-
v8::Maybe<bool> mark_arraybuffer_as_untransferable(
17-
v8::Local<v8::ArrayBuffer> ab) const override;
1816
void CallFinalizer(napi_finalize cb, void* data, void* hint) override;
1917
template <bool enforceUncaughtExceptionPolicy>
2018
void CallFinalizer(napi_finalize cb, void* data, void* hint);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.