nodejs
diff --git a/Collapse file
‎lib/tls.js‎
Copy file name to clipboardExpand all lines: lib/tls.js
+7-10Lines changed: 7 additions & 10 deletions b/Collapse file
‎lib/tls.js‎
Copy file name to clipboardExpand all lines: lib/tls.js
+7-10Lines changed: 7 additions & 10 deletions
diff --git a/Collapse file
‎test/parallel/test-tls-basic-validations.js‎
Copy file name to clipboardExpand all lines: test/parallel/test-tls-basic-validations.js
+9Lines changed: 9 additions & 0 deletions b/Collapse file
‎test/parallel/test-tls-basic-validations.js‎
Copy file name to clipboardExpand all lines: test/parallel/test-tls-basic-validations.js
+9Lines changed: 9 additions & 0 deletions
@@ -51,22 +51,19 @@ function convertProtocols(protocols) {
 exports.convertNPNProtocols  = function(protocols, out) {
   // If protocols is Array - translate it into buffer
   if (Array.isArray(protocols)) {
-    protocols = convertProtocols(protocols);
-  }
-  // If it's already a Buffer - store it
-  if (protocols instanceof Buffer) {
-    out.NPNProtocols = protocols;
+    out.NPNProtocols = convertProtocols(protocols);
+  } else if (protocols instanceof Buffer) {
+    // Copy new buffer not to be modified by user.
+    out.NPNProtocols = Buffer.from(protocols);
   }
 };
 
 exports.convertALPNProtocols = function(protocols, out) {
   // If protocols is Array - translate it into buffer
   if (Array.isArray(protocols)) {
-    protocols = convertProtocols(protocols);
-  }
-  // If it's already a Buffer - store it
-  if (protocols instanceof Buffer) {
-    // copy new buffer not to be modified by user
+    out.ALPNProtocols = convertProtocols(protocols);
+  } else if (protocols instanceof Buffer) {
+    // Copy new buffer not to be modified by user.
     out.ALPNProtocols = Buffer.from(protocols);
   }
 };
 
@@ -17,3 +17,12 @@ const tls = require('tls');
   assert(buffer.equals(Buffer.from('abcd')));
   assert(out.NPNProtocols.equals(Buffer.from('efgh')));
 }
+
+{
+  const buffer = Buffer.from('abcd');
+  const out = {};
+  tls.convertALPNProtocols(buffer, out);
+  out.ALPNProtocols.write('efgh');
+  assert(buffer.equals(Buffer.from('abcd')));
+  assert(out.ALPNProtocols.equals(Buffer.from('efgh')));
+}