Commit a667ac1
test: fix flaky timers-block-eventloop test
Due to extensive reliance on timings and the fs module, this test
is currently inherently flaky. Refactor it to simply use setImmediate
and only one busy loop.
PR-URL: #18567
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 6ed4e69 commit a667ac1Copy full SHA for a667ac1
File tree
Expand file treeCollapse file tree
1 file changed
+11
-17
lines changedOpen diff view settings
Filter options
- test/sequential
Expand file treeCollapse file tree
1 file changed
+11
-17
lines changedOpen diff view settings
Collapse file
test/sequential/test-timers-block-eventloop.js
Copy file name to clipboard+11-17Lines changed: 11 additions & 17 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
3 | 3 | |
4 | | - |
5 | | - |
| 4 | + |
6 | 5 | |
| 6 | + |
7 | 7 | |
8 | | - |
9 | | - |
10 | | - |
11 | | - |
12 | | - |
13 | | - |
14 | | - |
15 | | - |
16 | | - |
17 | | - |
18 | | - |
19 | | - |
| 8 | + |
| 9 | + |
| 10 | + |
20 | 11 | |
21 | 12 | |
22 | | - |
23 | | - |
24 | | - |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
0 commit comments