Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a6377a9

Browse filesBrowse files
captainsafiaaddaleax
authored andcommitted
test: increase coverage for lib/events.js
Adds tests for the case in which listeners() is invoked on a EventEmitter with no events. Adds a new test case for the situation in which a class inherits from the EventEmitter but overrides the constructor in the EventEmitter so that the _events is never set. PR-URL: #9865 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent 65cda7f commit a6377a9
Copy full SHA for a6377a9

File tree

Expand file treeCollapse file tree

1 file changed

+14
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+14
-0
lines changed
Open diff view settings
Collapse file

‎test/parallel/test-event-emitter-listeners.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-event-emitter-listeners.js
+14Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,12 @@
33
require('../common');
44
const assert = require('assert');
55
const events = require('events');
6+
const util = require('util');
67

78
function listener() {}
89
function listener2() {}
10+
class TestStream { constructor() { } }
11+
util.inherits(TestStream, events.EventEmitter);
912

1013
{
1114
const ee = new events.EventEmitter();
@@ -49,3 +52,14 @@ function listener2() {}
4952
ee.once('foo', listener2);
5053
assert.deepStrictEqual(ee.listeners('foo'), [listener, listener2]);
5154
}
55+
56+
{
57+
const ee = new events.EventEmitter();
58+
ee._events = undefined;
59+
assert.deepStrictEqual(ee.listeners('foo'), []);
60+
}
61+
62+
{
63+
const s = new TestStream();
64+
assert.deepStrictEqual(s.listeners('foo'), []);
65+
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.