Commit a618dc3
test: use CHECK instead of EXPECT where necessary
GetPageSize() and OverrunGuardedBuffer currently use non-fatal EXPECT_*
macros because GoogleTest does not allow the fatal variants ASSERT_* in
non-void returning functions (i.e., in this file, nowhere outside of the
TEST itself).
The EXPECT_* macros continue execution upon failure, but we really don't
want that (and static analysis apparently does not like it either).
Since we cannot use GoogleTest's ASSERT_* here, use our own CHECK_*
instead of EXPECT_* outside of the TEST. Hopefully, this will finally
pacify static analysis.
Refs: #44666
PR-URL: #44795
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>1 parent ffba321 commit a618dc3Copy full SHA for a618dc3
File tree
Expand file treeCollapse file tree
1 file changed
+9
-9
lines changedOpen diff view settings
Filter options
- test/cctest
Expand file treeCollapse file tree
1 file changed
+9
-9
lines changedOpen diff view settings
Collapse file
test/cctest/test_crypto_clienthello.cc
Copy file name to clipboardExpand all lines: test/cctest/test_crypto_clienthello.cc+9-9Lines changed: 9 additions & 9 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
32 | 32 | |
33 | 33 | |
34 | 34 | |
35 | | - |
| 35 | + |
36 | 36 | |
37 | 37 | |
38 | 38 | |
| ||
49 | 49 | |
50 | 50 | |
51 | 51 | |
52 | | - |
| 52 | + |
53 | 53 | |
54 | 54 | |
55 | 55 | |
56 | 56 | |
57 | 57 | |
58 | | - |
| 58 | + |
59 | 59 | |
60 | | - |
| 60 | + |
61 | 61 | |
62 | 62 | |
63 | 63 | |
64 | 64 | |
65 | 65 | |
66 | | - |
| 66 | + |
67 | 67 | |
68 | 68 | |
69 | | - |
70 | | - |
| 69 | + |
| 70 | + |
71 | 71 | |
72 | 72 | |
73 | 73 | |
74 | 74 | |
75 | 75 | |
76 | 76 | |
77 | | - |
| 77 | + |
78 | 78 | |
79 | 79 | |
80 | 80 | |
| ||
92 | 92 | |
93 | 93 | |
94 | 94 | |
95 | | - |
| 95 | + |
96 | 96 | |
97 | 97 | |
98 | 98 | |
|
0 commit comments