Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit a6053dc

Browse filesBrowse files
yashLadhadanielleadams
yashLadha
authored and
danielleadams
committed
src: add context for TODO comment in env.cc
Add more context around the TODO change required for achieving the task. When destructuring the isolate and environment_vars from the environment object, it is leading to recursive dependency and thus not able to refactor it in a better way. PR-URL: #37140 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 354df9e commit a6053dc
Copy full SHA for a6053dc

File tree

Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-1
lines changed
Open diff view settings
Collapse file

‎src/env.cc‎

Copy file name to clipboardExpand all lines: src/env.cc
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,8 @@ Environment::Environment(IsolateData* isolate_data,
372372

373373
set_env_vars(per_process::system_environment);
374374
// TODO(joyeecheung): pass Isolate* and env_vars to it instead of the entire
375-
// env
375+
// env, when the recursive dependency inclusion in "debug-utils.h" is
376+
// resolved.
376377
enabled_debug_list_.Parse(this);
377378

378379
// We create new copies of the per-Environment option sets, so that it is

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.