Commit a5f214c
crypto: replace THROW with CHECK for scrypt keylen
The JS layer already uses validateInt32(keylen, 'keylen', 0) to ensure
that the keylen argument fits into a signed 32-bit integer, thus, the
THROW statement in C++ is unreachable (unless the binding is accessed
directly, of course).
PR-URL: #47407
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 64a5fe0 commit a5f214cCopy full SHA for a5f214c
File tree
Expand file treeCollapse file tree
2 files changed
+9
-4
lines changedOpen diff view settings
Filter options
- src/crypto
- test/parallel
Expand file treeCollapse file tree
2 files changed
+9
-4
lines changedOpen diff view settings
Collapse file
src/crypto/crypto_scrypt.cc
Copy file name to clipboardExpand all lines: src/crypto/crypto_scrypt.cc+1-4Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
109 | 109 | |
110 | 110 | |
111 | 111 | |
112 | | - |
113 | | - |
114 | | - |
115 | | - |
| 112 | + |
116 | 113 | |
117 | 114 | |
118 | 115 | |
|
Collapse file
test/parallel/test-crypto-scrypt.js
Copy file name to clipboardExpand all lines: test/parallel/test-crypto-scrypt.js+8Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
143 | 143 | |
144 | 144 | |
145 | 145 | |
| 146 | + |
| 147 | + |
| 148 | + |
| 149 | + |
146 | 150 | |
147 | 151 | |
148 | 152 | |
149 | 153 | |
| 154 | + |
| 155 | + |
| 156 | + |
| 157 | + |
150 | 158 | |
151 | 159 | |
152 | 160 | |
|
0 commit comments