Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a5cce79

Browse filesBrowse files
Vladimir Varankincjihrig
authored andcommitted
console: delete timers that have ended
Currently, console timers that have been ended with timeEnd() are not removed. This has the potential to leak memory. This commit deletes ended timers from the containing Map. PR-URL: #3562 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
1 parent d9734b7 commit a5cce79
Copy full SHA for a5cce79

File tree

Expand file treeCollapse file tree

2 files changed

+11
-0
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+11
-0
lines changed
Open diff view settings
Collapse file

‎lib/console.js‎

Copy file name to clipboardExpand all lines: lib/console.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ Console.prototype.timeEnd = function(label) {
6868
const duration = process.hrtime(time);
6969
const ms = duration[0] * 1000 + duration[1] / 1e6;
7070
this.log('%s: %sms', label, ms.toFixed(3));
71+
this._times.delete(label);
7172
};
7273

7374

Collapse file

‎test/parallel/test-console.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-console.js
+10Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,16 @@ console.timeEnd('hasOwnProperty');
5757

5858
global.process.stdout.write = stdout_write;
5959

60+
// verify that console.timeEnd() doesn't leave dead links
61+
const timesMapSize = console._times.size;
62+
console.time('label1');
63+
console.time('label2');
64+
console.time('label3');
65+
console.timeEnd('label1');
66+
console.timeEnd('label2');
67+
console.timeEnd('label3');
68+
assert.strictEqual(console._times.size, timesMapSize);
69+
6070
assert.equal('foo\n', strings.shift());
6171
assert.equal('foo bar\n', strings.shift());
6272
assert.equal('foo bar hop\n', strings.shift());

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.