Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a587623

Browse filesBrowse files
codebytereaduh95
authored andcommitted
src: conditionally disable source phase imports by default
PR-URL: #60364 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7003082 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent fabf8e4 commit a587623
Copy full SHA for a587623

File tree

Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Open diff view settings
Collapse file

‎src/node.cc‎

Copy file name to clipboardExpand all lines: src/node.cc
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -780,7 +780,10 @@ static ExitCode ProcessGlobalArgsInternal(std::vector<std::string>* args,
780780
env_opts->abort_on_uncaught_exception = true;
781781
}
782782

783-
v8_args.emplace_back("--js-source-phase-imports");
783+
if (std::ranges::find(v8_args, "--no-js-source-phase-imports") ==
784+
v8_args.end()) {
785+
v8_args.emplace_back("--js-source-phase-imports");
786+
}
784787

785788
#ifdef __POSIX__
786789
// Block SIGPROF signals when sleeping in epoll_wait/kevent/etc. Avoids the

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.