Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a507308

Browse filesBrowse files
legendecasaduh95
authored andcommitted
tools: fix inspector_protocol updater
`.github/workflows/tools.yml` creates a temp file `temp-output` in the workspace, which fails `git status` clean repo check. Also, the GHA checks out a new branch after the update script. Removes these checks in the `roll.py` to fix its run on the GHA. PR-URL: #60277 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
1 parent 9e6d6ce commit a507308
Copy full SHA for a507308

File tree

Expand file treeCollapse file tree

1 file changed

+0
-12
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-12
lines changed
Open diff view settings
Collapse file

‎tools/inspector_protocol/roll.py‎

Copy file name to clipboardExpand all lines: tools/inspector_protocol/roll.py
-12Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,6 @@ def CheckRepoIsClean(path):
4747
raise Exception('%s is not a clean git repo (run git status)' % path)
4848

4949

50-
def CheckRepoIsNotAtMainBranch(path):
51-
os.chdir(path)
52-
stdout = RunCmd(['git', 'rev-parse', '--abbrev-ref', 'HEAD']).strip()
53-
if stdout == 'main':
54-
raise Exception('%s is at main branch - refusing to copy there.' % path)
55-
56-
5750
def CheckRepoIsInspectorProtocolCheckout(path):
5851
os.chdir(path)
5952
revision = RunCmd(['git', 'config', '--get', 'remote.origin.url']).strip()
@@ -123,12 +116,7 @@ def main(argv):
123116
downstream = os.path.normpath(os.path.expanduser(
124117
args.node_src_downstream))
125118
CheckRepoIsClean(upstream)
126-
CheckRepoIsClean(downstream)
127119
CheckRepoIsInspectorProtocolCheckout(upstream)
128-
# Check that the destination Git repo isn't at the main branch - it's
129-
# generally a bad idea to check into the main branch, so we catch this
130-
# common pilot error here early.
131-
CheckRepoIsNotAtMainBranch(downstream)
132120

133121
# Read V8's inspector_protocol revision
134122
v8_ip_revision = ReadV8IPRevision(downstream)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.