Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a4d67c9

Browse filesBrowse files
Vasili SkurydzinMylesBorins
authored andcommitted
deps: cherry-pick a51f429 from V8 upstream
Original commit message: Use gn from PATH on aix Change-Id: I853f7899dbba9112ba1ca2ce78e2838b5a09c975 Reviewed-on: https://chromium-review.googlesource.com/1168087 Commit-Queue: John Barboza <jbarboza@ca.ibm.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55028} PR-URL: #23695 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Yang Guo <yangguo@chromium.org> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
1 parent 01544e1 commit a4d67c9
Copy full SHA for a4d67c9

File tree

Expand file treeCollapse file tree

2 files changed

+3
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+3
-5
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
# Reset this number to 0 on major V8 upgrades.
3535
# Increment by one for each non-official patch applied to deps/v8.
36-
'v8_embedder_string': '-node.40',
36+
'v8_embedder_string': '-node.41',
3737

3838
# Enable disassembler for `--print-code` v8 options
3939
'v8_enable_disassembler': 1,
Collapse file

‎deps/v8/tools/mb/mb.py‎

Copy file name to clipboardExpand all lines: deps/v8/tools/mb/mb.py
+2-4Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -832,14 +832,12 @@ def GNCmd(self, subcommand, path, *args):
832832
subdir, exe = 'linux64', 'gn'
833833
elif self.platform == 'darwin':
834834
subdir, exe = 'mac', 'gn'
835-
elif self.platform == 'aix6':
836-
subdir, exe = 'aix', 'gn'
837835
else:
838836
subdir, exe = 'win', 'gn.exe'
839837

840838
arch = platform.machine()
841-
if (self.platform == 'linux2' and
842-
(arch.startswith('s390') or arch.startswith('ppc'))):
839+
if (arch.startswith('s390') or arch.startswith('ppc') or
840+
self.platform.startswith('aix')):
843841
# use gn in PATH
844842
gn_path = 'gn'
845843
else:

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.