Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a416692

Browse filesBrowse files
committed
repl: remove deprecated repl.memory function
This removes the memory function. It is deprecated for a long time while not being really helpful being exposed. Thus, it is removed to improve maintainability of the REPL module. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent f217b2d commit a416692
Copy full SHA for a416692

File tree

Expand file treeCollapse file tree

3 files changed

+4
-21
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+4
-21
lines changed
Open diff view settings
Collapse file

‎doc/api/deprecations.md‎

Copy file name to clipboardExpand all lines: doc/api/deprecations.md
+4-1Lines changed: 4 additions & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -1696,12 +1696,15 @@ file descriptors.
16961696
### DEP0082: `REPLServer.prototype.memory()`
16971697
<!-- YAML
16981698
changes:
1699+
- version: REPLACEME
1700+
pr-url: https://github.com/nodejs/node/pull/33286
1701+
description: End-of-Life.
16991702
- version: v9.0.0
17001703
pr-url: https://github.com/nodejs/node/pull/16242
17011704
description: Runtime deprecation.
17021705
-->
17031706
1704-
Type: Runtime
1707+
Type: End-of-Life
17051708
17061709
`REPLServer.prototype.memory()` is only necessary for the internal mechanics of
17071710
the `REPLServer` itself. Do not use this function.
Collapse file

‎lib/repl.js‎

Copy file name to clipboardExpand all lines: lib/repl.js
-5Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1352,11 +1352,6 @@ REPLServer.prototype.defineCommand = function(keyword, cmd) {
13521352
this.commands[keyword] = cmd;
13531353
};
13541354

1355-
REPLServer.prototype.memory = deprecate(
1356-
_memory,
1357-
'REPLServer.memory() is deprecated',
1358-
'DEP0082');
1359-
13601355
// TODO(BridgeAR): This should be replaced with acorn to build an AST. The
13611356
// language became more complex and using a simple approach like this is not
13621357
// sufficient anymore.
Collapse file

‎test/parallel/test-repl-memory-deprecation.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-repl-memory-deprecation.js
-15Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.