Commit a3e8829
inspector: do not hardcode Debugger.CallFrameId in tests
Debugger.CallFrameId is defined as an opaque string [1].
Some tests currently hardcode the value, relying on
undocumented internal details of V8. This makes it hard
for V8 to change the internal representation.
We should instead use the reported call frame id from
the Debugger.paused event directly. This is how every
inspector client does it.
[1] https://chromedevtools.github.io/devtools-protocol/tot/Debugger/#type-CallFrameId
PR-URL: #35570
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 5fea51b commit a3e8829Copy full SHA for a3e8829
File tree
Expand file treeCollapse file tree
3 files changed
+13
-4
lines changedOpen diff view settings
Filter options
- test
- common
- parallel
- sequential
Expand file treeCollapse file tree
3 files changed
+13
-4
lines changedOpen diff view settings
Collapse file
test/common/inspector-helper.js
Copy file name to clipboardExpand all lines: test/common/inspector-helper.js+9Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
130 | 130 | |
131 | 131 | |
132 | 132 | |
| 133 | + |
133 | 134 | |
134 | 135 | |
135 | 136 | |
| ||
179 | 180 | |
180 | 181 | |
181 | 182 | |
| 183 | + |
| 184 | + |
| 185 | + |
| 186 | + |
182 | 187 | |
183 | 188 | |
184 | 189 | |
| ||
267 | 272 | |
268 | 273 | |
269 | 274 | |
| 275 | + |
| 276 | + |
| 277 | + |
| 278 | + |
270 | 279 | |
271 | 280 | |
272 | 281 | |
|
Collapse file
test/parallel/test-inspector-esm.js
Copy file name to clipboardExpand all lines: test/parallel/test-inspector-esm.js+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
78 | 78 | |
79 | 79 | |
80 | 80 | |
81 | | - |
| 81 | + |
82 | 82 | |
83 | 83 | |
84 | 84 | |
|
Collapse file
test/sequential/test-inspector.js
Copy file name to clipboardExpand all lines: test/sequential/test-inspector.js+3-3Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
116 | 116 | |
117 | 117 | |
118 | 118 | |
119 | | - |
| 119 | + |
120 | 120 | |
121 | 121 | |
122 | 122 | |
| ||
150 | 150 | |
151 | 151 | |
152 | 152 | |
153 | | - |
| 153 | + |
154 | 154 | |
155 | 155 | |
156 | 156 | |
| ||
276 | 276 | |
277 | 277 | |
278 | 278 | |
279 | | - |
| 279 | + |
280 | 280 | |
281 | 281 | |
282 | 282 | |
|
0 commit comments