Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a367c0d

Browse filesBrowse files
aduh95codebytere
authored andcommitted
timers: refactor to use more primordials
PR-URL: #36132 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 142cacd commit a367c0d
Copy full SHA for a367c0d

File tree

Expand file treeCollapse file tree

1 file changed

+7
-4
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+7
-4
lines changed
Open diff view settings
Collapse file

‎lib/timers/promises.js‎

Copy file name to clipboardExpand all lines: lib/timers/promises.js
+7-4Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
'use strict';
22

33
const {
4+
FunctionPrototypeBind,
45
Promise,
56
PromisePrototypeFinally,
67
PromiseReject,
@@ -72,8 +73,9 @@ function setTimeout(after, value, options = {}) {
7273
if (!ref) timeout.unref();
7374
insert(timeout, timeout._idleTimeout);
7475
if (signal) {
75-
// eslint-disable-next-line no-undef
76-
oncancel = cancelListenerHandler.bind(timeout, clearTimeout, reject);
76+
oncancel = FunctionPrototypeBind(cancelListenerHandler,
77+
// eslint-disable-next-line no-undef
78+
timeout, clearTimeout, reject);
7779
signal.addEventListener('abort', oncancel);
7880
}
7981
});
@@ -121,8 +123,9 @@ function setImmediate(value, options = {}) {
121123
const immediate = new Immediate(resolve, [value]);
122124
if (!ref) immediate.unref();
123125
if (signal) {
124-
// eslint-disable-next-line no-undef
125-
oncancel = cancelListenerHandler.bind(immediate, clearImmediate, reject);
126+
oncancel = FunctionPrototypeBind(cancelListenerHandler,
127+
// eslint-disable-next-line no-undef
128+
immediate, clearImmediate, reject);
126129
signal.addEventListener('abort', oncancel);
127130
}
128131
});

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.