Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit a2e4643

Browse filesBrowse files
joyeecheungMoLow
joyeecheung
authored and
MoLow
committed
test: use random port in NodeInstance.startViaSignal()
Which makes it possible to run the tests that use this in parallel. PR-URL: #47412 Refs: #47146 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 670f9a5 commit a2e4643
Copy full SHA for a2e4643

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎test/common/inspector-helper.js‎

Copy file name to clipboardExpand all lines: test/common/inspector-helper.js
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ class NodeInstance extends EventEmitter {
372372

373373
static async startViaSignal(scriptContents) {
374374
const instance = new NodeInstance(
375-
['--expose-internals'],
375+
['--expose-internals', '--inspect-port=0'],
376376
`${scriptContents}\nprocess._rawDebug('started');`, undefined);
377377
const msg = 'Timed out waiting for process to start';
378378
while (await fires(instance.nextStderrString(), msg, TIMEOUT) !== 'started');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.