Commit a256790
test: fix flaky cluster-net-send
Before this commit, it was possible on Windows for the server's
'connection' handler to be called *after* the client socket's
'connect' handler. This caused the 'message' event to be missed
and the test would never end (timing out in CI). This problem
was more easily reproducible on a low resource (slow CPU)
Windows (2012r2) installation.
This commit waits until both handlers have been called before
sending the handle to the master process.
Fixes: #3957
PR-URL: #4444
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 6809c2b commit a256790Copy full SHA for a256790
File tree
Expand file treeCollapse file tree
2 files changed
+9
-4
lines changedOpen diff view settings
Filter options
- test/parallel
Expand file treeCollapse file tree
2 files changed
+9
-4
lines changedOpen diff view settings
Collapse file
test/parallel/parallel.status
Copy file name to clipboardExpand all lines: test/parallel/parallel.status-1Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
7 | 7 | |
8 | 8 | |
9 | 9 | |
10 | | - |
11 | 10 | |
12 | 11 | |
13 | 12 | |
|
Collapse file
test/parallel/test-cluster-net-send.js
Copy file name to clipboardExpand all lines: test/parallel/test-cluster-net-send.js+9-3Lines changed: 9 additions & 3 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
31 | 31 | |
32 | 32 | |
33 | 33 | |
| 34 | + |
| 35 | + |
| 36 | + |
| 37 | + |
| 38 | + |
| 39 | + |
| 40 | + |
34 | 41 | |
35 | 42 | |
36 | 43 | |
37 | 44 | |
38 | 45 | |
| 46 | + |
39 | 47 | |
40 | 48 | |
41 | | - |
42 | | - |
43 | | - |
| 49 | + |
44 | 50 | |
45 | 51 | |
46 | 52 | |
|
0 commit comments