Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit a17d398

Browse filesBrowse files
cclausstargos
cclauss
authored and
targos
committed
deps: V8: cherry-pick e3d7f8a
Original commit message: [build] update gen-postmortem-metadata for Python 3 This change makes the code compatible with both Python 2 and Python 3. Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63207} Refs: v8/v8@e3d7f8a PR-URL: #29105 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 0a63e2d commit a17d398
Copy full SHA for a17d398

File tree

Expand file treeCollapse file tree

2 files changed

+3
-7
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+3
-7
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.14',
41+
'v8_embedder_string': '-node.15',
4242

4343
##### V8 defaults for Node.js #####
4444

Collapse file

‎deps/v8/tools/gen-postmortem-metadata.py‎

Copy file name to clipboardExpand all lines: deps/v8/tools/gen-postmortem-metadata.py
+2-6Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -640,9 +640,7 @@ def emit_config():
640640

641641
out.write('/* class type information */\n');
642642
consts = [];
643-
keys = typeclasses.keys();
644-
keys.sort();
645-
for typename in keys:
643+
for typename in sorted(typeclasses):
646644
klass = typeclasses[typename];
647645
consts.append({
648646
'name': 'type_%s__%s' % (klass, typename),
@@ -653,9 +651,7 @@ def emit_config():
653651

654652
out.write('/* class hierarchy information */\n');
655653
consts = [];
656-
keys = klasses.keys();
657-
keys.sort();
658-
for klassname in keys:
654+
for klassname in sorted(klasses):
659655
pklass = klasses[klassname]['parent'];
660656
bklass = get_base_class(klassname);
661657
if (bklass != 'Object'):

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.