Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit a15bfda

Browse filesBrowse files
Trotttargos
Trott
authored and
targos
committed
test: remove string literal message from assertion
Remove string literal message in assert.strictEqual() call in napi test testFinalizer.js. Backport-PR-URL: #22912 PR-URL: #22849 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent e580a44 commit a15bfda
Copy full SHA for a15bfda

File tree

Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-2
lines changed
Open diff view settings
Collapse file

‎test/addons-napi/test_general/testFinalizer.js‎

Copy file name to clipboardExpand all lines: test/addons-napi/test_general/testFinalizer.js
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,4 @@ test_general.wrap(finalizeAndWrap);
2929
test_general.addFinalizerOnly(finalizeAndWrap, common.mustCall());
3030
finalizeAndWrap = null;
3131
global.gc();
32-
assert.strictEqual(test_general.derefItemWasCalled(), true,
33-
'finalize callback was called');
32+
assert.strictEqual(test_general.derefItemWasCalled(), true);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.